refactor(CLI): Modern logs for slstats command
#10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10036 +/- ##
==========================================
- Coverage 85.88% 85.76% -0.13%
==========================================
Files 333 333
Lines 13416 13427 +11
==========================================
- Hits 11523 11515 -8
- Misses 1893 1912 +19
Continue to review full report at Codecov.
|
medikoo
reviewed
Oct 1, 2021
lib/plugins/slstats.js
Outdated
| @@ -25,11 +26,15 @@ class SlStats { | |||
| if (enableStats) { | |||
| // set .serverlessrc config | |||
| config.set('trackingDisabled', false); | |||
| this.serverless.cli.log('Stats successfully enabled'); | |||
| const message = 'Stats successfully enabled'; | |||
There was a problem hiding this comment.
Same, here, let's not create variables to be ditched in v3 branch
pgrzesik
force-pushed
the
modern-logs-for-slstats
branch
from
24a70d1
to
1ad9cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #9860