refactor(CLI): Modern logs for config-related command
#10038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10038 +/- ##
==========================================
- Coverage 85.88% 85.75% -0.14%
==========================================
Files 333 333
Lines 13416 13432 +16
==========================================
- Hits 11523 11518 -5
- Misses 1893 1914 +21
Continue to review full report at Codecov.
|
medikoo
reviewed
Oct 1, 2021
lib/plugins/aws/configCredentials.js
Outdated
| `Failed! ~/.aws/credentials already has a "${this.options.profile}" profile. Use the overwrite flag ("-o" or "--overwrite") to force the update` | ||
| ); | ||
| log.notice.skip( | ||
| `Profile "${this.options.profile}" is already configured in ~/.aws/credentials. Use the overwrite flag ("-o" or "--overwrite") to force the update.` |
There was a problem hiding this comment.
This feels more as an error. I would I think convert it to ServerlessError exception
lib/plugins/config.js
Outdated
| @@ -80,7 +81,9 @@ class Config { | |||
| } | |||
| if (this.options.autoupdate) { | |||
| if (config.get('autoUpdate.enabled')) { | |||
| this.serverless.cli.log('Auto update is already turned on'); | |||
| const message = 'Auto update is already turned on'; | |||
There was a problem hiding this comment.
Let's not generalize to vars
pgrzesik
force-pushed
the
modern-logs-for-config
branch
from
678db89
to
3d667ab
Compare
pgrzesik
force-pushed
the
modern-logs-for-config
branch
from
13632a2
to
09b979a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #9860