Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CLI): Modern logs for install command #10040

Merged
merged 1 commit into from Oct 1, 2021

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Oct 1, 2021

Addresses: #9860

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #10040 (c83266d) into master (f73062f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c83266d differs from pull request most recent head acf7d5e. Consider uploading reports for the commit acf7d5e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10040   +/-   ##
=======================================
  Coverage   85.88%   85.89%           
=======================================
  Files         333      333           
  Lines       13416    13422    +6     
=======================================
+ Hits        11523    11529    +6     
  Misses       1893     1893           
Impacted Files Coverage Δ
lib/cli/write-service-outputs.js 83.33% <ø> (-2.39%) ⬇️
lib/cli/handle-error.js 85.71% <100.00%> (-0.29%) ⬇️
lib/plugins/aws/deploy/index.js 100.00% <100.00%> (ø)
lib/plugins/aws/info/index.js 100.00% <100.00%> (ø)
lib/plugins/aws/logs.js 87.71% <100.00%> (-0.42%) ⬇️
lib/plugins/aws/utils/formatLambdaLogEvent.js 100.00% <100.00%> (ø)
lib/plugins/install.js 100.00% <100.00%> (ø)
lib/utils/downloadTemplateFromRepo.js 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73062f...acf7d5e. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo October 1, 2021 14:00
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

(as a side note, it's a command we should probably consider deprecated, and hide soon, but nonetheless I think we need to refactor them to new logs anyway)

@pgrzesik
Copy link
Contributor Author

pgrzesik commented Oct 1, 2021

Fully agree, I wanted to bring up this command during our next meeting as I think this command is not really used much and is just a worse version of create (which also might become deprecated) 👍

@pgrzesik pgrzesik merged commit bd4d215 into master Oct 1, 2021
@pgrzesik pgrzesik deleted the modern-logs-install-command branch October 1, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants