New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Lambda: Support 64-bit ARM architecture #10049
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10049 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 333 333
Lines 13435 13439 +4
=======================================
+ Hits 11521 11525 +4
Misses 1914 1914
Continue to review full report at Codecov.
|
f1ea9a8
to
e3b54fb
Compare
```yml | ||
provider: | ||
... | ||
arch: arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arch: arm64 | |
architecture: arm64 |
The word isn't really long so we might as well be explicit for clarity? Additionally the CloudFormation setting is Architectures
, not Arch
/Archs
so we gain a bit in consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually followed the spec from the issue, which was confirmed as accepted.
Anyway I also thought about that, and I agree that using architecture
is probably better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ok I understand better, I thought the original post (top comment of the issue) was just a suggestion. So I'm guessing for anything discussed on GitHub the practice is to discuss and update the top comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, issue serves as specification then
662f26f
to
44c9174
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(only reviewed the docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, let's also add property to layers
|
||
By default, Lambda functions are run by 64-bit x86 architecture CPUs. However, using arm64 architecture (AWS Graviton2 processor) may result in better pricing and performance. | ||
|
||
To switch all lambdas to AWS Graviton2 processor, configure `arch` at `provider` level as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's write all functions
instead of all lambdas
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 changed
2811a10
to
589217e
Compare
@pgrzesik very good point, added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, I only have one small suggestion related to docs
@@ -597,6 +599,9 @@ layers: | |||
description: Description of what the lambda layer does # optional, Description to publish to AWS | |||
compatibleRuntimes: # optional, a list of runtimes this layer is compatible with | |||
- python3.8 | |||
compatibleArchitectures: # optional, a list of architectures this layer is compatible with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add a reference to this setting in layers.md
documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @pgrzesik Added
589217e
to
9cfba13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
Closes: #10025
Additionally cleaned up lambda based fixtures, to create better room for the testing general lambda related enhancements