Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CLI): Modern logs for metrics command #10051

Merged
merged 1 commit into from Oct 4, 2021

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Oct 4, 2021

Addresses: #9860

For implementation I took inspiration from sls info command:

metrics

@pgrzesik pgrzesik force-pushed the modern-logs-for-metrics-command branch from 82ed774 to 5dcd89d Compare October 4, 2021 15:21
@pgrzesik pgrzesik requested a review from medikoo October 4, 2021 15:30
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #10051 (5dcd89d) into master (f8ad7bc) will decrease coverage by 0.20%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10051      +/-   ##
==========================================
- Coverage   85.75%   85.55%   -0.21%     
==========================================
  Files         333      333              
  Lines       13435    13447      +12     
==========================================
- Hits        11521    11504      -17     
- Misses       1914     1943      +29     
Impacted Files Coverage Δ
lib/plugins/aws/metrics.js 57.97% <11.11%> (-42.03%) ⬇️
lib/plugins/aws/provider.js 93.71% <0.00%> (ø)
lib/plugins/aws/package/compile/functions.js 94.38% <0.00%> (+0.03%) ⬆️
lib/plugins/aws/package/compile/layers.js 84.94% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ad7bc...5dcd89d. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@pgrzesik pgrzesik merged commit 592596c into master Oct 4, 2021
@pgrzesik pgrzesik deleted the modern-logs-for-metrics-command branch October 4, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants