CLI: Improve modern logs for create stack #10053
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10053 +/- ##
=======================================
Coverage 85.53% 85.53%
=======================================
Files 333 333
Lines 13473 13473
=======================================
Hits 11524 11524
Misses 1949 1949
Continue to review full report at Codecov.
|
lib/plugins/aws/lib/monitorStack.js
Outdated
| if ((completedResources.size || inProgressResources.size) && action !== 'create') { | ||
| const progressMessagePrefix = (() => { | ||
| if (action === 'update') return 'Updating'; | ||
| if (action === 'delete') return 'Deleting'; |
There was a problem hiding this comment.
It should result in Removing instead of Deleting to be consistent with our wording (it has been changed in one of recent PRs)
medikoo
force-pushed
the
1004-improve-logs
branch
from
5147b79
to
b4a922c
Compare
scripts/serverless.js
Outdated
| @@ -901,5 +909,6 @@ const processSpanPromise = (async () => { | |||
| }); | |||
| } finally { | |||
| clearTimeout(keepAliveTimer); | |||
| log.notice(); // Ensure breathing line at the end of output | |||
There was a problem hiding this comment.
Should we have that in? I generally like the idea and I think we could use it in more places, but I remember that e.g. @mnapoli mentioned that we should not do it as people might have terminals configured to automatically print/render empty line after commands.
There was a problem hiding this comment.
Good point, I just assumed it's good to have that (design docs are not explicit on intention, as they do not show prompt after finalized output). Anyway let's first clarify with @mnapoli
There was a problem hiding this comment.
As we discussed on Slack, currently there's an agreement to add this in (but it's possible we'll revert that)
There was a problem hiding this comment.
Actually reverting that (following further discission on slack)
medikoo
force-pushed
the
1004-improve-logs
branch
from
b4a922c
to
26f9ce8
Compare
Addresses: #9860