Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CLI): Modern logs for create command #10066

Merged
merged 1 commit into from Oct 7, 2021

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Oct 7, 2021

Addresses: #9860

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #10066 (d1edd70) into master (7c91cde) will decrease coverage by 0.06%.
The diff coverage is 82.89%.

❗ Current head d1edd70 differs from pull request most recent head 5cdd167. Consider uploading reports for the commit 5cdd167 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10066      +/-   ##
==========================================
- Coverage   85.53%   85.46%   -0.07%     
==========================================
  Files         333      333              
  Lines       13473    13499      +26     
==========================================
+ Hits        11524    11537      +13     
- Misses       1949     1962      +13     
Impacted Files Coverage Δ
lib/classes/ConfigSchemaHandler/index.js 91.61% <ø> (+1.08%) ⬆️
...ns/aws/package/lib/mergeCustomProviderResources.js 78.78% <0.00%> (+2.31%) ⬆️
lib/plugins/deploy.js 100.00% <ø> (+5.26%) ⬆️
lib/plugins/package/package.js 100.00% <ø> (+3.70%) ⬆️
lib/plugins/standalone.js 40.74% <0.00%> (-2.40%) ⬇️
commands/plugin-install.js 62.16% <50.00%> (-0.34%) ⬇️
commands/plugin-uninstall.js 64.17% <50.00%> (-0.44%) ⬇️
lib/plugins/aws/lib/monitorStack.js 95.29% <66.66%> (+1.74%) ⬆️
lib/plugins/create/create.js 85.71% <81.25%> (-3.48%) ⬇️
lib/plugins/aws/deploy/lib/uploadArtifacts.js 90.81% <81.81%> (+0.09%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c91cde...5cdd167. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo October 7, 2021 14:03
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@pgrzesik pgrzesik merged commit 05f937f into master Oct 7, 2021
@pgrzesik pgrzesik deleted the modern-logs-for-create branch October 7, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants