Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CLI): Minor modern logs updates #10071

Merged
merged 1 commit into from Oct 8, 2021
Merged

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Oct 8, 2021

Addresses: #9860

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #10071 (e7add00) into master (05f937f) will increase coverage by 0.00%.
The diff coverage is 77.77%.

❗ Current head e7add00 differs from pull request most recent head 588b656. Consider uploading reports for the commit 588b656 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10071   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         333      333           
  Lines       13538    13537    -1     
=======================================
  Hits        11562    11562           
+ Misses       1976     1975    -1     
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/functions.js 94.42% <60.00%> (+0.03%) ⬆️
lib/plugins/aws/lib/monitorStack.js 96.25% <100.00%> (+0.95%) ⬆️
...vents/apiGateway/lib/hack/disassociateUsagePlan.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f937f...588b656. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo October 8, 2021 14:58
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pgrzesik pgrzesik merged commit 39c09e4 into master Oct 8, 2021
@pgrzesik pgrzesik deleted the minor-adjustments-to-logs branch October 8, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants