New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CLI): Replace process.stdout
use with modern logs
#10087
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10087 +/- ##
=======================================
Coverage 85.38% 85.39%
=======================================
Files 333 334 +1
Lines 13571 13604 +33
=======================================
+ Hits 11588 11617 +29
- Misses 1983 1987 +4
Continue to review full report at Codecov.
|
@@ -21,5 +21,6 @@ module.exports = (commandName) => { | |||
} | |||
if (commandSchema) renderOptionsHelp(Object.assign({}, commandSchema.options)); | |||
|
|||
process.stdout.write('\n'); | |||
legacy.consoleLog(''); | |||
writeText(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this confirmed needed for modern logs? (Technically help output was done, and accepted as is currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to keep it the same as it's right now, it needs to be added - process.stdout.write('\n')
is now printed unconditionally, if I remove it without adding replacement for modern logs the output will change (unless I'm missing something?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! That's correct then :)
7e05bfc
to
7c7aa08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Addresses: #9860
Replace leftover
process.stdout
usages with modern logs