fix(AWS Deploy): Recognize LogicalResourceId in stackPolicy
#10097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmonsma
changed the title
medikoo
suggested changes
Oct 14, 2021
lib/plugins/aws/provider.js
Outdated
| @@ -578,6 +585,10 @@ class AwsProvider { | |||
| additionalProperties: false, | |||
| required: ['securityGroupIds', 'subnetIds'], | |||
| }, | |||
| awsLogicalResourceId: { | |||
| type: 'string', | |||
| pattern: '^[#A-Za-z0-9-_./]+[*]?', | |||
There was a problem hiding this comment.
I believe we need a pattern for full string (so with $ at the end), as otherwise we allow any string after matching string, and that will not make a valid resource id
There was a problem hiding this comment.
Thanks, completely overlooked this one. I fixed the pattern.
medikoo
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #10097 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 334 334
Lines 13604 13604
=======================================
Hits 11617 11617
Misses 1987 1987
Continue to review full report at Codecov.
|
pgrzesik
changed the title
LogicalResourceId in stackPolicy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According the Cloudformation documentation it should support single and wildcard logical ID's
Addresses #10095