CLI: Improve handling of service outputs in modern logs #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10100 +/- ##
==========================================
+ Coverage 85.39% 85.41% +0.01%
==========================================
Files 334 334
Lines 13604 13608 +4
==========================================
+ Hits 11617 11623 +6
+ Misses 1987 1985 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I've tried to keep general stack info outside of
addServiceOutputSectioninterface, still it doesn't work will with eventual extensions added by the plugins, e.g. it resulted with dashboard URL put in the middle of table, where it should stay at the top. This patch ensures expected order