refactor(CLI): Report credentials source in modern error output
#10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10114 +/- ##
=======================================
Coverage 85.26% 85.27%
=======================================
Files 334 335 +1
Lines 13638 13687 +49
=======================================
+ Hits 11628 11671 +43
- Misses 2010 2016 +6
Continue to review full report at Codecov.
|
medikoo
reviewed
Oct 19, 2021
lib/cli/handle-error.js
Outdated
| if (serverless && serverless.service.provider.name === 'aws') { | ||
| const credentials = serverless.getProvider('aws').cachedCredentials; | ||
| if (credentials) { | ||
| if (credentials.dashboardProviderAlias && serverless.pluginManager.dashboardPlugin) { |
There was a problem hiding this comment.
Wouldn't checking credentials.dashboardProviderAlias be good enough?
There was a problem hiding this comment.
I wanted to be extra sure with checking if dashboardPlugin instance is available as well, but I think there shouldn't be any situations when that wouldn't be the case
edit: changed
pgrzesik
force-pushed
the
report-source-of-credentials-in-error-output
branch
from
7698bd6
to
9d49a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #9860