Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS EventBridge): Adjust deprecation of deployment method #10133

Merged
merged 1 commit into from Oct 22, 2021

Conversation

pgrzesik
Copy link
Contributor

Reported internally

This PR adjusts the deprecation and signals that in v3 it will still be possible to use the Custom Resource-based deployment method for EventBridge resources.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10133 (673e9a6) into master (7cfddff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10133   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         337      337           
  Lines       13723    13723           
=======================================
  Hits        11713    11713           
  Misses       2010     2010           
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 94.29% <ø> (ø)
...ns/aws/package/compile/events/eventBridge/index.js 98.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfddff...673e9a6. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@pgrzesik pgrzesik merged commit bf62b7c into master Oct 22, 2021
@pgrzesik pgrzesik deleted the adjust-eventbridge-deprecation-setting branch October 22, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants