Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize accessible configuration parts on validation errors #10134

Merged
merged 1 commit into from Oct 22, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 22, 2021

When preparing v3 branch approached an issue, where framework version validation error prevented loading plugins for help output. One of the tests failed on that.

Ensure to apply validation after accessible configuration parts are assigned internally

@medikoo medikoo self-assigned this Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10134 (f252f29) into master (bf62b7c) will increase coverage by 0.00%.
The diff coverage is 76.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10134   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         337      337           
  Lines       13723    13725    +2     
=======================================
+ Hits        11713    11715    +2     
  Misses       2010     2010           
Impacted Files Coverage Δ
lib/classes/Service.js 85.71% <76.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf62b7c...f252f29. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik October 22, 2021 12:57
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit b7a6349 into master Oct 22, 2021
@medikoo medikoo deleted the 1022-improve-config-error-handling branch October 22, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants