CLI: Improve file size output in logs #10169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10169 +/- ##
==========================================
+ Coverage 85.35% 85.37% +0.02%
==========================================
Files 337 339 +2
Lines 13725 13819 +94
==========================================
+ Hits 11715 11798 +83
- Misses 2010 2021 +11
Continue to review full report at Codecov.
|
pgrzesik
previously approved these changes
Oct 27, 2021
mnapoli
reviewed
Oct 27, 2021
medikoo
force-pushed
the
1026-filesize
branch
from
e86b542
to
eb85194
Compare
mnapoli
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decision to apply that was done in context of modern logs, still I think it's not harmful to apply it also to old logs