feat: Allow legacy option for lambdaHashingVersion property
#10173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10173 +/- ##
==========================================
- Coverage 85.37% 85.34% -0.03%
==========================================
Files 339 339
Lines 13819 13822 +3
==========================================
- Hits 11798 11797 -1
- Misses 2021 2025 +4
Continue to review full report at Codecov.
|
mnapoli
reviewed
Oct 28, 2021
medikoo
reviewed
Oct 28, 2021
pgrzesik
force-pushed
the
allow-to-use-old-hashing-algorithm
branch
from
940137b
to
494d00c
Compare
mnapoli
previously approved these changes
Nov 2, 2021
medikoo
reviewed
Nov 3, 2021
| @@ -147,7 +148,7 @@ class AwsCompileFunctions { | |||
|
|
|||
| async addFileToHash(filePath, hash) { | |||
| const lambdaHashingVersion = this.serverless.service.provider.lambdaHashingVersion; | |||
| if (lambdaHashingVersion) { | |||
| if (lambdaHashingVersion === '20201221') { | |||
There was a problem hiding this comment.
Nit: Conceptually we should rather use >= comparison (although it's highly unlikely we will introduce any other mode in a future)
| @@ -62,7 +62,8 @@ class AwsCompileFunctions { | |||
| 'LAMBDA_HASHING_VERSION_V2', | |||
| 'Resolution of lambda version hashes was improved with better algorithm, ' + | |||
| 'which will be used in next major release.\n' + | |||
| 'Switch to it now by setting "provider.lambdaHashingVersion" to "20201221"' | |||
| 'Switch to it now by setting "provider.lambdaHashingVersion" to "20201221".\n' + | |||
| 'While it is highly encouraged to upgrade to new algorithm, you can still use the old approach by setting "provider.lambdaHashingVersion" to "legacy".' | |||
There was a problem hiding this comment.
legacy should be updated to 20200924
pgrzesik
force-pushed
the
allow-to-use-old-hashing-algorithm
branch
from
494d00c
to
2c74f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use
legacyoption forlambdaHashingVersionto keep using the old algorithmReported internally