Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Improve main progress message #10183

Merged
merged 1 commit into from Nov 2, 2021
Merged

CLI: Improve main progress message #10183

merged 1 commit into from Nov 2, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 2, 2021

Small improvement requested internally

@medikoo medikoo self-assigned this Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #10183 (6b3a44d) into master (d202af1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10183   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         339      339           
  Lines       13819    13819           
=======================================
  Hits        11800    11800           
  Misses       2019     2019
Impacted Files Coverage Δ
lib/plugins/aws/deploy/index.js 98.63% <100.00%> (ø)
lib/plugins/aws/info/index.js 97.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d202af1...6b3a44d. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik November 2, 2021 14:03
pgrzesik
pgrzesik approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@medikoo medikoo merged commit 533f709 into master Nov 2, 2021
@medikoo medikoo deleted the 1102-improve-progress-deploy-message branch November 2, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrzesik pgrzesik pgrzesik approved these changes

Assignees

@medikoo medikoo

Labels
cat/cli refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@medikoo @pgrzesik