Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate internal and plugin output sections #10184

Merged
merged 1 commit into from Nov 2, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 2, 2021

Goal is to show sections as introduced by plugins after sections set in the core. For that we need to use different section collections.

This PR proposes so serverless.addServiceOutputSection is dedicated just for use within plugins, and internally we add sections directly into serviceOutputs collection.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #10184 (ef65159) into master (d202af1) will decrease coverage by 0.04%.
The diff coverage is 76.47%.

❗ Current head ef65159 differs from pull request most recent head 968010b. Consider uploading reports for the commit 968010b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10184      +/-   ##
==========================================
- Coverage   85.38%   85.34%   -0.05%     
==========================================
  Files         339      339              
  Lines       13819    13822       +3     
==========================================
- Hits        11800    11797       -3     
- Misses       2019     2025       +6     
Impacted Files Coverage Δ
lib/Serverless.js 66.96% <33.33%> (-2.51%) ⬇️
lib/plugins/aws/info/display.js 75.67% <80.00%> (ø)
lib/plugins/aws/deploy/index.js 98.64% <100.00%> (+0.01%) ⬆️
lib/plugins/aws/info/index.js 97.22% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d202af1...968010b. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik November 2, 2021 14:19
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@medikoo medikoo merged commit 7bb2520 into master Nov 2, 2021
@medikoo medikoo deleted the 1102-seprate-plugin-outputs branch November 2, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants