Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Do not recomment frameworkVersion when running pre release #10204

Merged
merged 1 commit into from Nov 5, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 5, 2021

When playing with v3 pre-release spotted the following log, I think we should not recommend setting frameworkVersion when pre-release is run:

To ensure safe major version upgrades ensure "frameworkVersion" setting in service configuration (recommended setup: "frameworkVersion: ^3.0.0-pre")

@medikoo medikoo self-assigned this Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #10204 (150d0e1) into master (6a2be57) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 150d0e1 differs from pull request most recent head f37cd06. Consider uploading reports for the commit f37cd06 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10204   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         339      339           
  Lines       13831    13831           
=======================================
  Hits        11806    11806           
  Misses       2025     2025           
Impacted Files Coverage Δ
lib/classes/Service.js 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2be57...f37cd06. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik November 5, 2021 14:17
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 53490a5 into master Nov 5, 2021
@medikoo medikoo deleted the 1105-fix-prerelease-version-handling branch November 5, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants