Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Refactor missed cli.log usage #10206

Merged
merged 2 commits into from Nov 5, 2021
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 5, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #10206 (9acb779) into master (53490a5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9acb779 differs from pull request most recent head 4ef69aa. Consider uploading reports for the commit 4ef69aa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10206      +/-   ##
==========================================
- Coverage   85.35%   85.35%   -0.01%     
==========================================
  Files         339      339              
  Lines       13831    13831              
==========================================
- Hits        11806    11805       -1     
- Misses       2025     2026       +1     
Impacted Files Coverage Δ
lib/plugins/aws/remove/lib/bucket.js 100.00% <100.00%> (ø)
lib/classes/CLI.js 57.14% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53490a5...4ef69aa. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit ecf2918 into master Nov 5, 2021
@medikoo medikoo deleted the 1105-refactor-missing-logs branch November 5, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants