feat: Introduce enforce-hash-update flag to help hashing migration
#10209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10209 +/- ##
==========================================
+ Coverage 85.35% 85.38% +0.03%
==========================================
Files 339 339
Lines 13831 13836 +5
==========================================
+ Hits 11805 11814 +9
+ Misses 2026 2022 -4
Continue to review full report at Codecov.
|
medikoo
reviewed
Nov 8, 2021
docs/guides/upgrading-v3.md
Outdated
|
|
||
| By default, Lambda version hashes will now be generated using improved algorithm (fixed determinism issues). As it is a breaking change that requires more manual effort during migration, it is still possible (but not recommended) to keep using old algorithm by using the following configuration: | ||
|
|
||
| ```` |
There was a problem hiding this comment.
I think it should be one back quote less
docs/guides/upgrading-v3.md
Outdated
| @@ -236,7 +260,7 @@ provider: | |||
| statements: ... | |||
| managedPolicies: ... | |||
| deploymentRole: ... | |||
| ``` | |||
| ```` | |||
There was a problem hiding this comment.
And then this change should not happen
pgrzesik
force-pushed
the
introduce-enforce-hash-update-option
branch
from
5779071
to
5938c6a
Compare
mnapoli
reviewed
Nov 8, 2021
pgrzesik
force-pushed
the
introduce-enforce-hash-update-option
branch
from
5938c6a
to
0ed9b37
Compare
pgrzesik
force-pushed
the
introduce-enforce-hash-update-option
branch
from
0ed9b37
to
25201f1
Compare
mnapoli
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported internally, introduce a way to ease the lambda hashing algorithm migration