Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve timestamp visiblity in deploy list output #10211

Merged
merged 1 commit into from Nov 9, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 9, 2021

Deployment timestamp serves as an identifier which is used e.g. in rollback -t <timestamp> command.
Therefore we improve its visibility in deploy list command

Changes output of deploy list from:
Screenshot 2021-11-09 at 12 10 20

Into:

Screenshot 2021-11-09 at 12 12 11

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #10211 (83b9ac0) into master (e8c8d25) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 83b9ac0 differs from pull request most recent head 8599de6. Consider uploading reports for the commit 8599de6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10211   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         339      339           
  Lines       13829    13829           
=======================================
  Hits        11803    11803           
  Misses       2026     2026           
Impacted Files Coverage Δ
lib/plugins/aws/deployList.js 71.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c8d25...8599de6. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik November 9, 2021 11:35
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 55146c4 into master Nov 9, 2021
@medikoo medikoo deleted the 1109-improve-deploy-list branch November 9, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants