fix(AWS API Gateway): Ensure proper apiId resolution

[pgrzesik]

Closes: #10220

related: #10177

cc @vicary

[vicary]

@pgrzesik Thanks heaps!

[codecov]

Codecov Report

Merging #10221 (5ccc594) into master (1829550) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10221   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         339      339           
  Lines       13836    13836           
=======================================
  Hits        11814    11814           
  Misses       2022     2022           

Impacted Files	Coverage Δ
.../compile/events/apiGateway/lib/hack/updateStage.js	95.06% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1829550...5ccc594. Read the comment docs.

[medikoo]

Why this was not picked by test, which is supposed to test that case?

[pgrzesik]

Why this was not picked by test, which is supposed to test that case?

When investigating, I've realized that it's not really possible to test it with unit tests, as the use case where the apiName has to be generated and is not available in compiled CloudFormation does not happen if no plugins are involved so the test wasn't really covering that case. I've changed the test to be more generic and left it as we don't have too many runServerless tests that cover that part of logic.

[medikoo]

Thanks for explanations, makes sense