Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS S3): Support Fn::If CF function for s3 event #10272

Merged
merged 1 commit into from Nov 25, 2021

Conversation

pgrzesik
Copy link
Contributor

Closes: #10270

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #10272 (02865d1) into master (44511f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10272   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         339      339           
  Lines       13842    13842           
=======================================
  Hits        11821    11821           
  Misses       2021     2021           
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/s3/index.js 98.54% <ø> (ø)
lib/plugins/aws/provider.js 94.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44511f3...02865d1. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@pgrzesik pgrzesik merged commit a4fa498 into master Nov 25, 2021
@pgrzesik pgrzesik deleted the support-if-for-s3-event branch November 25, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF conditionals throw warning errors under functions property (Configuration warning)
2 participants