Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Ensure complete resolution of address and params values #10296

Merged
merged 6 commits into from Dec 2, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 1, 2021

Fixes: #10294

Addresses scenarios where address or param is constructed of variables, which resolve with strings that contain variables. Such case was handled properly for end property values (#9657), but remained not addressed for internal results that play part in variables resolution.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #10296 (9915cac) into master (d52526b) will increase coverage by 0.00%.
The diff coverage is 89.55%.

❗ Current head 9915cac differs from pull request most recent head a6b2a35. Consider uploading reports for the commit a6b2a35 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10296   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         339      339           
  Lines       13877    13901   +24     
=======================================
+ Hits        11852    11873   +21     
- Misses       2025     2028    +3     
Impacted Files Coverage Δ
lib/configuration/variables/resolve.js 97.72% <89.55%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52526b...a6b2a35. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@medikoo medikoo merged commit 63d54e1 into master Dec 2, 2021
@medikoo medikoo deleted the 1201-fix-deep-vars-resolution branch December 2, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested configuration is not resolved in cloud formation resolver
2 participants