Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS SQS): Support filterPatterns #10297

Merged
merged 1 commit into from Dec 1, 2021
Merged

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Dec 1, 2021

Closes: #10284

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #10297 (0055b83) into master (d52526b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0055b83 differs from pull request most recent head 592eae1. Consider uploading reports for the commit 592eae1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10297   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         339      339           
  Lines       13877    13880    +3     
=======================================
+ Hits        11852    11855    +3     
  Misses       2025     2025           
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/stream.js 98.23% <ø> (ø)
lib/plugins/aws/provider.js 94.97% <ø> (ø)
lib/plugins/aws/package/compile/events/sqs.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52526b...592eae1. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo December 1, 2021 16:40
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@pgrzesik pgrzesik merged commit 3f0a80a into master Dec 1, 2021
@pgrzesik pgrzesik deleted the support-sqs-filter-patterns branch December 1, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add event filtering capabilites to stream (dynamodb, kinesis) and sqs events
2 participants