Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): allow false values in aws provider configuration #10324

Closed
wants to merge 1 commit into from
Closed

fix(aws): allow false values in aws provider configuration #10324

wants to merge 1 commit into from

Conversation

fargito
Copy link
Contributor

@fargito fargito commented Dec 8, 2021

Hello ! Thanks for the hard work.

In aws provider, is currently not possible to put falsy values for some configuration keys. This PR will enable per-stage configuration that is currently not possible

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fargito thanks for taking an action for that. Still most of those properties were intentionally defined that way.

They are about migration from deprecated properties, and we allow only true values, as only true will be supported in v3 (and these properties will be deprecated as meaningless in v3).

The only exceptions are:

  • shouldStartNameWithService for both http and httpApi, we wanted to force that setting, but we've resigned from doing that, so I think we can indeed relax it to true/false
  • disableRollback - I believe it's a bug that this property was configured as const: true, from a start it should be boolen.

Summarizing, let's update schema only for the above properties, and PR will be good to merge

@fargito
Copy link
Contributor Author

fargito commented Dec 9, 2021

Hello @medikoo I restricted the changes to the forementionned 😉

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #10324 (39af9a4) into master (b8cc13f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10324   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         340      340           
  Lines       13990    13990           
=======================================
  Hits        11943    11943           
  Misses       2047     2047           
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 94.97% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8cc13f...39af9a4. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fargito !

@medikoo
Copy link
Contributor

medikoo commented Dec 9, 2021

Taken via three distinct commits.

@medikoo medikoo closed this Dec 9, 2021
@fargito fargito deleted the fix/aws-boolean-validation branch December 9, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants