feat(AWS API Gateway): Allow use of custom authorizer with authorizerId #10384
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10384 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 340 340
Lines 14005 14005
=======================================
Hits 11957 11957
Misses 2048 2048
Continue to review full report at Codecov.
|
| @@ -235,6 +235,52 @@ describe('#validate()', () => { | |||
| expect(() => awsCompileApigEvents.validate()).not.to.throw(Error); | |||
| }); | |||
|
|
|||
| it('should throw when using a CUSTOM authorizer without an authorizer id', () => { | |||
There was a problem hiding this comment.
For a long time now we're only accepting new tests written with using runServerless utility and are slowly migrating away from the old approach. Could you please cover it with such tests instead?
There was a problem hiding this comment.
No problem, sorry I had missed that earlier in the test README.
| }, | ||
| }, | ||
| }, | ||
| }).then(({ awsNaming: naming, cfTemplate }) => { |
There was a problem hiding this comment.
Let's use async/await instead of then
| @@ -235,6 +235,69 @@ describe('#validate()', () => { | |||
| expect(() => awsCompileApigEvents.validate()).not.to.throw(Error); | |||
| }); | |||
|
|
|||
| it('should throw when using a CUSTOM authorizer without an authorizer id', async () => { | |||
There was a problem hiding this comment.
Let's move these two tests into the second describe at the bottom of the file that has only runServerless based tests
|
Rebased with master to get the coverage report to pass. |
pgrzesik
changed the title
Closes: #8769