Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Support custom sources in internal resolver #10393

Merged
merged 1 commit into from Dec 20, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 20, 2021

Needed for dashboard plugin variables test refactor

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #10393 (7443cba) into master (352553e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7443cba differs from pull request most recent head 405a826. Consider uploading reports for the commit 405a826 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10393   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         340      340           
  Lines       14004    14005    +1     
=======================================
+ Hits        11956    11957    +1     
  Misses       2048     2048           
Impacted Files Coverage Δ
lib/configuration/variables/index.js 90.47% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352553e...405a826. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 365a7f1 into master Dec 20, 2021
@medikoo medikoo deleted the 1220-improve-variables-resolve-util branch December 20, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants