Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal old logging utils with modern interface #10417

Merged
merged 1 commit into from Dec 23, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 23, 2021

Spotted those modules when working on #10414

Missed complement to #9860

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #10417 (d989568) into master (4fa20a5) will increase coverage by 0.06%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10417      +/-   ##
==========================================
+ Coverage   85.37%   85.43%   +0.06%     
==========================================
  Files         340      336       -4     
  Lines       14013    13999      -14     
==========================================
- Hits        11963    11960       -3     
+ Misses       2050     2039      -11     
Impacted Files Coverage Δ
lib/utils/telemetry/index.js 77.77% <50.00%> (-1.17%) ⬇️
lib/utils/yamlAstParser.js 97.29% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa20a5...d989568. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 5a451ad into master Dec 23, 2021
@medikoo medikoo deleted the 1223-remove-obsolete-modules branch December 23, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants