Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CLI Onboarding): Download templates from v2 examples branch #10447

Merged
merged 1 commit into from Jan 6, 2022

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Jan 4, 2022

Reported internally, ensure that v2 Framework uses examples from v2 branch for interactive onboarding.

@pgrzesik pgrzesik self-assigned this Jan 4, 2022
@pgrzesik pgrzesik force-pushed the use-v2-branch-from-examples-in-interactive branch from 171de1f to 4d51d30 Compare January 4, 2022 15:46
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #10447 (9459d6c) into master (dbb044c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9459d6c differs from pull request most recent head 4d51d30. Consider uploading reports for the commit 4d51d30 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10447   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         336      336           
  Lines       14003    14003           
=======================================
  Hits        11964    11964           
  Misses       2039     2039           
Impacted Files Coverage Δ
lib/cli/interactive-setup/service.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb044c...4d51d30. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo January 4, 2022 15:58
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Thinking it further, I think we need to make v2 a default branch in examples repo now, and after we release v3.0.0 switch to v3 being a default, and no longer work there with master branch (still we should keep it as alias of v2, to ensure it works with already released versions)

@pgrzesik
Copy link
Contributor Author

pgrzesik commented Jan 6, 2022

@medikoo I've made v2 the base branch in examples and set up the v3 branch as well.

@pgrzesik pgrzesik merged commit 46d090a into master Jan 6, 2022
@pgrzesik pgrzesik deleted the use-v2-branch-from-examples-in-interactive branch January 6, 2022 16:06
@medikoo
Copy link
Contributor

medikoo commented Jan 6, 2022

@pgrzesik that's great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants