Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Resign from projectDir concept #10478

Merged
merged 1 commit into from Jan 10, 2022
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jan 10, 2022

As decided internally, resign from projectDir concept.

After that change, files in variables can be resolved from any system path

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #10478 (8f84e58) into master (129c0ee) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8f84e58 differs from pull request most recent head 105c76a. Consider uploading reports for the commit 105c76a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10478      +/-   ##
==========================================
- Coverage   85.89%   85.88%   -0.01%     
==========================================
  Files         335      335              
  Lines       13934    13931       -3     
==========================================
- Hits        11968    11965       -3     
  Misses       1966     1966              
Impacted Files Coverage Δ
lib/configuration/variables/sources/file.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129c0ee...105c76a. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik January 10, 2022 10:07
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 5a76437 into master Jan 10, 2022
@medikoo medikoo deleted the 0110-remove-project-dir branch January 10, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants