Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Templates): Ensure esbuild dependency in aws-nodejs-typescript #10484

Merged
merged 2 commits into from Jan 10, 2022
Merged

fix(Templates): Ensure esbuild dependency in aws-nodejs-typescript #10484

merged 2 commits into from Jan 10, 2022

Conversation

fargito
Copy link
Contributor

@fargito fargito commented Jan 10, 2022

Explicitely define esbuild dev dependency in aws-nodejs-typescript since serverless-esbuild added it as a peer dependency

Closes: #10470

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @fargito 🙇

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #10484 (01c9642) into master (0cc7774) will not change coverage.
The diff coverage is n/a.

❗ Current head 01c9642 differs from pull request most recent head 6752569. Consider uploading reports for the commit 6752569 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10484   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         335      335           
  Lines       13931    13931           
=======================================
  Hits        11958    11958           
  Misses       1973     1973           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc7774...6752569. Read the comment docs.

@pgrzesik pgrzesik changed the title [aws-nodejs-typescript]: explicit esbuild dependency fix(Templates): Ensure esbuild dependency in aws-nodejs-typescript Jan 10, 2022
@pgrzesik pgrzesik merged commit 452e4d8 into serverless:master Jan 10, 2022
@fargito fargito deleted the fix/aws-node-esbuild branch January 10, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot find module 'esbuild'" error when installing aws-nodejs-typescript template
2 participants