Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup obsolete TODO comments #10496

Merged
merged 2 commits into from Jan 12, 2022
Merged

Cleanup obsolete TODO comments #10496

merged 2 commits into from Jan 12, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jan 12, 2022

TODO comments in most cases indicate changes proposed for the next major (so they're not lost).

Some of them are no longer actual, or were left over by mistake. This PR cleans that up.

Additionally improved log on custom resource building. It's a long time it doesn't involve npm install and yet log messages suggested that)

@medikoo medikoo self-assigned this Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #10496 (cf6ba41) into master (452e4d8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cf6ba41 differs from pull request most recent head ca74b9b. Consider uploading reports for the commit ca74b9b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10496   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         335      335           
  Lines       13931    13931           
=======================================
  Hits        11958    11958           
  Misses       1973     1973           
Impacted Files Coverage Δ
lib/classes/CLI.js 57.14% <ø> (ø)
lib/configuration/variables/index.js 90.47% <ø> (ø)
lib/plugins/aws/provider.js 94.97% <ø> (ø)
lib/plugins/aws/customResources/index.js 98.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452e4d8...ca74b9b. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik January 12, 2022 15:15
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@medikoo medikoo merged commit 521861b into master Jan 12, 2022
@medikoo medikoo deleted the 0112-cleanup-obsolete-todo branch January 12, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants