CLI: Respect old Node.js versions in version detection #10499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
force-pushed
the
0113-fix-node-version-validation
branch
from
1875835
to
243ef68
Compare
Codecov Report
@@ Coverage Diff @@
## master #10499 +/- ##
==========================================
- Coverage 85.83% 85.83% -0.01%
==========================================
Files 335 335
Lines 13931 13930 -1
==========================================
- Hits 11958 11957 -1
Misses 1973 1973
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on local fallback updates, I've realized our Node.js version detection works well only in recent versions of Node.js
e.g. if someone attempts to run Framework with Node.js v6 will see an ugly syntax error. This patch fixes that, and configures test to prevent further regression in that area.