Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Support conceal option in modern logs #10501

Merged
merged 1 commit into from Jan 14, 2022

Conversation

pgrzesik
Copy link
Contributor

Reported internally

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #10501 (9bab087) into master (427920e) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10501      +/-   ##
==========================================
- Coverage   85.83%   85.83%   -0.01%     
==========================================
  Files         335      335              
  Lines       13930    13931       +1     
==========================================
  Hits        11957    11957              
- Misses       1973     1974       +1     
Impacted Files Coverage Δ
lib/plugins/aws/info/display.js 75.00% <50.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427920e...9bab087. Read the comment docs.

@pgrzesik pgrzesik requested a review from medikoo January 13, 2022 13:39
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we need to confirm on this change internally first

@pgrzesik pgrzesik requested a review from medikoo January 13, 2022 17:46
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@pgrzesik pgrzesik merged commit 0dacf1b into master Jan 14, 2022
@pgrzesik pgrzesik deleted the bring-back-support-for-conceal-option branch January 14, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants