refactor: Ensure support for warn mode for modern deprecations

[pgrzesik]

Reported internally

[codecov]

Codecov Report

Merging #10502 (6d169fe) into master (427920e) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

❗ Current head 6d169fe differs from pull request most recent head 685274b. Consider uploading reports for the commit 685274b to get more accurate results

@@            Coverage Diff             @@
##           master   #10502      +/-   ##
==========================================
- Coverage   85.83%   85.83%   -0.01%     
==========================================
  Files         335      335              
  Lines       13930    13935       +5     
==========================================
+ Hits        11957    11961       +4     
- Misses       1973     1974       +1     

Impacted Files	Coverage Δ
lib/plugins/aws/info/display.js	75.00% <50.00%> (-0.68%)	⬇️
lib/utils/logDeprecation.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427920e...685274b. Read the comment docs.

[medikoo]

Looks good, still, if I look correctly it doesn't cover well the scenario where just 1 deprecation was reported in summary mode. As then regular writeDeprecation function is used, and we've just now introduced modern logs to it.

So in modern logs on, with 1 deprecation, user will see both, a sls doctor notice and deprecation warning.

I think the only way to mitigate it is to rely on SLS_DEV_LOG_MODE and issue that log.warning only when have modern mode confirmed

[pgrzesik]

Good catch - I didn't test that scenario and didn't catch it

[medikoo]

Looks great 👍