Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Improve user message #10509

Merged
merged 1 commit into from Jan 14, 2022
Merged

CLI: Improve user message #10509

merged 1 commit into from Jan 14, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jan 14, 2022

Proposed internally by @ac360

@medikoo medikoo self-assigned this Jan 14, 2022
@medikoo medikoo changed the title CLI: Improve error message CLI: Improve user message Jan 14, 2022
@medikoo medikoo force-pushed the 0114-improve-onboarding-message branch from 5c1c999 to 897a8f8 Compare January 14, 2022 08:41
@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited

Codecov Report

Merging #10509 (897a8f8) into master (427920e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10509   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         335      335           
  Lines       13930    13930           
=======================================
  Hits        11957    11957           
  Misses       1973     1973
Impacted Files Coverage Δ
lib/cli/interactive-setup/dashboard-set-org.js 95.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427920e...897a8f8. Read the comment docs.

pgrzesik
pgrzesik approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 20afe33 into master Jan 14, 2022
@medikoo medikoo deleted the 0114-improve-onboarding-message branch January 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrzesik pgrzesik pgrzesik approved these changes

@mnapoli mnapoli Awaiting requested review from mnapoli

Assignees

@medikoo medikoo

Labels
cat/ci enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@medikoo @pgrzesik