addressing-7747;-config.js

[pjmattingly]

Addresses: #7747

[pjmattingly]

Working on #7747, changes to /lib/classes/config.js

[codecov]

Codecov Report

Merging #11266 (4075ab4) into main (bb37f4f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4075ab4 differs from pull request most recent head e690267. Consider uploading reports for the commit e690267 to get more accurate results

@@            Coverage Diff             @@
##             main   #11266      +/-   ##
==========================================
- Coverage   85.89%   85.89%   -0.01%     
==========================================
  Files         315      315              
  Lines       13247    13246       -1     
==========================================
- Hits        11378    11377       -1     
  Misses       1869     1869              

Impacted Files	Coverage Δ
lib/classes/config.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb37f4f...e690267. Read the comment docs.

[pgrzesik]

Did you have a chance to trace if that would be a safe refactor here? Merge does deep copy and assign does only a shallow copy, I think such generic function as this one might be potentially dangerous to rely on just shallow copy

[pgrzesik]

I see you have another PR with bulk of the changes - should this one be closed @pjmattingly?

[pjmattingly]

Yes, it's a little embarrassing. I was thinking of making a pull request for each change on #7747; Then I realized that would be a pain in the butt to approve, so I made the bulk PR instead.