Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace _.flatten with Array.prototype.flat #11271

Merged
merged 2 commits into from Jul 28, 2022
Merged

refactor: Replace _.flatten with Array.prototype.flat #11271

merged 2 commits into from Jul 28, 2022

Conversation

pjmattingly
Copy link
Contributor

Addresses: #7747

@pjmattingly pjmattingly mentioned this pull request Jul 24, 2022
54 tasks
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #11271 (469c0e0) into main (2ac55b0) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main   #11271      +/-   ##
==========================================
- Coverage   85.89%   85.87%   -0.02%     
==========================================
  Files         315      315              
  Lines       13247    13272      +25     
==========================================
+ Hits        11378    11397      +19     
- Misses       1869     1875       +6     
Impacted Files Coverage Δ
lib/plugins/aws/metrics.js 67.24% <0.00%> (ø)
lib/plugins/aws/deploy/lib/check-for-changes.js 96.31% <100.00%> (ø)
...package/compile/events/api-gateway/lib/api-keys.js 100.00% <100.00%> (ø)
...ackage/compile/events/websockets/lib/deployment.js 100.00% <100.00%> (ø)
...ib/plugins/aws/utils/get-s3-objects-from-stacks.js 100.00% <100.00%> (ø)
lib/plugins/aws/package/compile/events/http-api.js 96.65% <0.00%> (-0.05%) ⬇️
lib/cli/triage.js 91.34% <0.00%> (ø)
...ns/aws/package/compile/events/cognito-user-pool.js 100.00% <0.00%> (ø)
...urces/resources/cognito-user-pool/lib/user-pool.js 0.00% <0.00%> (ø)
...ib/plugins/aws/custom-resources/resources/utils.js 25.45% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac55b0...469c0e0. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pjmattingly, I have one comment, please let me know what do you think

lib/plugins/aws/deploy/lib/check-for-changes.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pjmattingly, it looks good 👍

@pgrzesik pgrzesik changed the title done refactor: Replace _.flatten with Array.prototype.flat Jul 28, 2022
@pgrzesik pgrzesik merged commit b36cdf2 into serverless:main Jul 28, 2022
@pjmattingly pjmattingly deleted the addressing-#7747,-Replace-_.flat-with-array.flat branch July 28, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants