New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace _.flatMap
with Array.prototype.flatMap
#11272
refactor: Replace _.flatMap
with Array.prototype.flatMap
#11272
Conversation
When addressing #7747 for _.flatmap, I noted that there were additional lodash calls that seemed similar. Both _.flattenDeep() and _.flattenDepth() can be replaced with Array.prototype.flat(); And so I took the liberty of making those small changes as well. |
Codecov Report
@@ Coverage Diff @@
## main #11272 +/- ##
==========================================
- Coverage 85.89% 85.87% -0.02%
==========================================
Files 315 315
Lines 13247 13273 +26
==========================================
+ Hits 11378 11398 +20
- Misses 1869 1875 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pjmattingly 🙇 I have one comment, please let me know what do you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @pjmattingly 👏 Thank you 🙇
_.flatMap
with Array.prototype.flatMap
Addresses: #7747