#7747;-Replace-_.set-with-normal-obj.prop-=-value-assignments

[pjmattingly]

Addresses: #7747

[pjmattingly]

Dissapointingly I could not remove _.set from any of its instances in customer facing code. Oddly, some instances of _.set seem to correspond to calls that are never run? Specifically, there are two instances of a forEach() over an empty array; See code changes for more details.

Each instance of _.set touched by this issue has been commented about why no changes were made.

[codecov]

Codecov Report

Merging #11273 (0af56d4) into main (2ac55b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11273   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         315      315           
  Lines       13247    13247           
=======================================
  Hits        11378    11378           
  Misses       1869     1869           

Impacted Files	Coverage Δ
lib/plugins/aws/deploy/lib/extended-validate.js	92.68% <ø> (ø)
lib/plugins/aws/package/lib/save-service-state.js	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac55b0...0af56d4. Read the comment docs.