New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove invalid variable references from the documentation #11785
remove invalid variable references from the documentation #11785
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 Thank you @duytrandev
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #11785 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 314 314
Lines 13128 13128
=======================================
Hits 11364 11364
Misses 1764 1764 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duytrandev can you ensure that changes follow Prettier formatting. CI failed due to that
hi @medikoo I updated my code to resolve the prettier issue |
|
@medikoo I got a lot of |
Maybe you have git configured on windows to change the end of line characters? |
hi @medikoo thanks for the pointer, I updated my workspace accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @duytrandev ! Great improvement.
Small hint: To mark PR as ready for re-review, best is to simply re-request review in reviewers box (we receive notification of such action)
Closes: #8306