Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor _.entries() to Object.entries() #11793

Merged

Conversation

sleepwithcoffee
Copy link
Contributor

@sleepwithcoffee sleepwithcoffee commented Mar 10, 2023

Addresses: #7747

There are 2 places that are left with _.entries()

Tested with:
npx mocha test/unit/lib/plugins/aws/package/compile/functions.test.js
npx mocha test/unit/lib/plugins/aws/package/compile/events/api-gateway/lib/request-validator.test.js

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ad8c24e) 86.56% compared to head (2b71c98) 86.56%.

❗ Current head 2b71c98 differs from pull request most recent head e528007. Consider uploading reports for the commit e528007 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11793   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         314      314           
  Lines       13128    13128           
=======================================
  Hits        11364    11364           
  Misses       1764     1764           
Impacted Files Coverage Δ
...ompile/events/api-gateway/lib/request-validator.js 98.07% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @duytrandev 👍

@medikoo medikoo merged commit 1181780 into serverless:main Mar 10, 2023
@sleepwithcoffee sleepwithcoffee deleted the 7747_lodash_entries_refactor branch March 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants