Replace BbPromise usages #11905
Merged
Replace BbPromise usages #11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change BbPromise.all() to common Promise
…e_all_test_folder
…e_all_test_folder
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #11905 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 316 316
Lines 13440 13440
=======================================
Hits 11651 11651
Misses 1789 1789 ☔ View full report in Codecov by Sentry. |
medikoo
suggested changes
May 9, 2023
There was a problem hiding this comment.
Thanks @sleepwithcoffee for taking care of that!
In general it looks really good, I've just suggested few changes
|
for some reason, it's picking another branch, hmm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7171