fix: Don't duplicate PolicyDocument statement for stream events (#12313) #12320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erless#12313) Each function consuming a stream event would emit its own PolicyDocument statement. This statement would contain a list of actions that doesn't change between functions. For DynamoDB streams the list is: ``` "Action": [ "dynamodb:GetRecords", "dynamodb:GetShardIterator", "dynamodb:DescribeStream", "dynamodb:ListStreams" ], ``` Duplicating these for each function causes the IAM policy to exceed the AWS limit after about 30 functions. The resource names are still duplicated, if they happen to be the same.
4 tasks
|
I ran |
|
I didn't implement de-duplication of resource names, as I'm not sure how to do so correctly in the preference of functions like In my case resource name de-duplication would be helpful, as even with this fix the DynamoDB table name is duplicated 30 times in the |
|
Anything else I can do to shepherd this along? |
|
Could someone please take look at this? This is rather problematic issue for large users of serverless. |
|
Ping |
|
Does this project accept external contributions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each function consuming a stream event would emit its own PolicyDocument statement. This statement would contain a list of actions that doesn't change between functions. For DynamoDB streams the list is:
Duplicating these for each function causes the IAM policy to exceed the AWS limit after about 30 functions.
The resource names are still duplicated, if they happen to be the same.
Closes: #12313