feat: Use nodejs18 in custom-resources and aws-sdk v3 #12445
Conversation
|
@xoapit thanks for taking the time and hope it will be merged asap :) Just little question, is there a specific reason to not already bump the runtime to nodejs20 ? I see that in the v4 branch it was already set to 20 so I guess it should work?! |
|
@tonivdv nodejs20 runtime is not available in AWS Cloud (US) https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/govcloud-lambda.html so I want to keep it as 18.x to make sure it works for all partitions |
|
When will you merge it? Node 16 is deprecated soon. So we need to fix it asap. |
|
No one from the serverless team reviews and merges the PR, no releases from Nov 2023. Hmm, It looks like they do not want to maintain version 3. |
|
Hi @xoapit , so should I use v4? |
|
V.4 introduces a new pricing model, please refer to https://www.serverless.com/blog/serverless-framework-v4-a-new-model |
|
Hi @xoapit , Thank you for your reply. I see. It's not good for me. Can you please help me how to download your PR to my local project? I can't wait. And it seems like they stopped to support this v3. |
|
@jeffrey1226 It won't work with your local project. You can apply a patch like this #12133 (comment) |
|
@xoapit Thanks for the PR. We will be looking into this in the coming days. V3 is still being maintained even with the team hard at work on V.4 beta coming out in a few days. |
|
Some additional clarity as well regarding AWS timelines; while AWS is marking June, 2024 as when Node 16 is deprecated, this will have no impact on deployments at that stage. AWS will only be blocking function create from February, 2025. |
Closes: #12133
Based on changes from #12146 by svoychik. He is not available to resolve the conflicts so I have recreated the PR based on that changes.