Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated packages with security vulnerabilities. #7466

Closed
wants to merge 1 commit into from

Conversation

bhtandev
Copy link

@bhtandev bhtandev commented Mar 16, 2020

What did you implement

Updated third party packages with security vulnerabilities. mkdirp and update-notifier.

These were detected by SYNK. Images shown below:

Screen Shot 2020-03-13 at 11 53 21 am

Screen Shot 2020-03-13 at 11 53 08 am

How can we verify it

Run existing tests

  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

…use mkdirp is promisified in new version already.
@bhtandev
Copy link
Author

Currently stuck as unit tests on for Nodejs 6 is failing because it is not happy with the new update-notifier package. (unexpected identifier - async )

@medikoo
Copy link
Contributor

medikoo commented Apr 2, 2020

@bhtandev great thanks for that PR. Still we cannot drop support for Node.js v6 now (it'll be a breaking change, that requires major bump).

Track #7486 for status on that

@medikoo medikoo closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants