Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to have secure dependencies (decompress & download) #7537

Conversation

preshetin
Copy link
Contributor

@preshetin preshetin commented Apr 2, 2020

What did you implement

Update to secure versions of decompress & download dependencies.

Closes #7402

How can we verify it

Run npm audit and you'll get this in the end (no high severity):

found 25 vulnerabilities (24 low, 1 moderate) in 8084 scanned packages
  run `npm audit fix` to fix 24 of them.

Todos

Useful Scripts
  • npm run test:ci --> Run all validation checks on proposed changes
  • npm run lint:updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check:updated --> Check if updated files adhere to Prettier config
  • npm run prettify:updated --> Prettify all the updated files
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@neverendingqs
Copy link
Contributor

FYI it sounds like this is done as part of every release: #7531 (comment)

@preshetin
Copy link
Contributor Author

@neverendingqs thanks Mark for letting me know. So should I better close this PR?

@neverendingqs
Copy link
Contributor

@preshetin yes I believe so.

@preshetin preshetin closed this Apr 2, 2020
@preshetin preshetin deleted the vulnerable-dependencies-decompress branch April 30, 2020 11:24
@Besiara
Copy link

Besiara commented May 15, 2020

Why you closed this PR, looks like the issue still persists. A version of download should be updated to 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerable dependancy
3 participants