Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash _.every(array) with native Array.every #7764

Merged
merged 1 commit into from May 26, 2020
Merged

Replace lodash _.every(array) with native Array.every #7764

merged 1 commit into from May 26, 2020

Conversation

chrisVillanueva
Copy link
Contributor

@chrisVillanueva chrisVillanueva commented May 21, 2020 •
edited by medikoo

Addresses: #7747

@chrisVillanueva chrisVillanueva changed the title Replace lodash _.every(array) with native Array.every #7747 Replace lodash _.every(array) with native Array.every May 21, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #7764 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7764   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files         246      246           
  Lines        9279     9279           
=======================================
  Hits         8176     8176           
  Misses       1103     1103
Impacted Files Coverage Δ
...package/compile/events/apiGateway/lib/resources.js 97.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd902e8...55ca3b8. Read the comment docs.

medikoo
medikoo approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrisVillanueva Looks great!

@medikoo medikoo merged commit d1721cb into serverless:master May 26, 2020
@exoego exoego mentioned this pull request May 26, 2020
Open
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
cat/dependency refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisVillanueva @codecov-commenter @medikoo